Page MenuHomePhabricator
Differential D13513

Modularize all remaining Pholio Herald fields
ClosedPublic
Actions

Authored by epriestley on Jul 1 2015, 3:05 PM.
Tags
None
Referenced Files
F18827688: D13513.diff
Fri, Oct 24, 11:30 AM
F18806901: D13513.id32673.diff
Sat, Oct 18, 9:59 PM
F18806500: D13513.id32785.diff
Sat, Oct 18, 7:55 PM
F18805833: D13513.id32785.diff
Sat, Oct 18, 4:43 PM
F18743811: D13513.id.diff
Fri, Oct 3, 12:56 AM
F18738567: D13513.diff
Wed, Oct 1, 4:04 PM
F18701192: D13513.diff
Sat, Sep 27, 5:51 PM
F18664754: D13513.diff
Sep 24 2025, 12:14 AM
View All Files
Subscribers
eadler
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8726: Modularize Herald fields and actions
Commits
Restricted Diffusion Commit
rP415e4d4cc135: Modularize all remaining Pholio Herald fields
Summary

Ref T8726. Use modular fields for the Pholio adapter.

Test Plan
  • Created rule using all the old fields.
  • Migrated, saw upgrade apply correctly.
  • Created mock, reviewed transcript.

Diff Detail

Repository
rP Phabricator
Branch
hmodular8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7096
Build 7244: [Placeholder Plan] Wait for 30 Seconds
Build 7243: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32673.Jul 1 2015, 3:05 PM
epriestley retitled this revision from to Modularize all remaining Pholio Herald fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8726: Modularize Herald fields and actions.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 1 2015, 3:05 PM
btrahan accepted this revision.Jul 1 2015, 5:29 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 1 2015, 5:29 PM
eadler added a subscriber: eadler.Jul 3 2015, 7:48 PM
Closed by commit rP415e4d4cc135: Modularize all remaining Pholio Herald fields (authored by epriestley, committed by epriestley). · Explain WhyJul 6 2015, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
20 lines
src/
10 lines
applications/
herald/
adapter/
11 lines
pholio/
herald/
herald/
adapter/
38 lines
pholio/
herald/
24 lines
24 lines
9 lines
24 lines

Diff 32673

View Options

resources/sql/autopatches/20150701.herald.1.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/pholio/herald/HeraldPholioMockAdapter.php

Loading...
View Options

src/applications/pholio/herald/PholioMockAuthorHeraldField.php

Loading...
View Options

src/applications/pholio/herald/PholioMockDescriptionHeraldField.php

Loading...
View Options

src/applications/pholio/herald/PholioMockHeraldField.php

Loading...
View Options

src/applications/pholio/herald/PholioMockNameHeraldField.php

Loading...
Phabricator · Built by Phacility