Page MenuHomePhabricator

[Redesign] Use status icons in Maniphest task list
ClosedPublic

Authored by chad on Jun 30 2015, 8:27 PM.
Tags
None
Referenced Files
F14054129: D13490.id32641.diff
Fri, Nov 15, 10:44 PM
F13985814: D13490.id.diff
Oct 20 2024, 11:00 PM
Unknown Object (File)
Oct 7 2024, 8:43 PM
Unknown Object (File)
Oct 3 2024, 11:49 PM
Unknown Object (File)
Sep 23 2024, 9:42 PM
Unknown Object (File)
Sep 10 2024, 3:21 AM
Unknown Object (File)
Aug 28 2024, 7:18 PM
Unknown Object (File)
Aug 27 2024, 10:51 AM
Subscribers

Details

Summary

Ref T8099, Fixes T8339. This lets us pull in the status icon and display in lists and object headers.

Test Plan

Look at a list of open and closed tasks, see icons match state (duplicate, spite, defaults).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to [Redesign] Use status icons in Maniphest task list.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/maniphest/view/ManiphestTaskListView.php
81

You can end up with the "grey" class twice, but that's probably okay. Otherwise, you could re-factor to something like this

$color = idx($color_map, $task->getPriority(), 'grey');
if ($task->isClosed()) {
  $item->setDisabled(true);
  $color = 'grey';
}
$icon .= ' '.$color;
This revision is now accepted and ready to land.Jun 30 2015, 8:34 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.