Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T8099: Mid-2015 Phabricator Redesign
T8339: Allow setting of icons in maniphest.status - Commits
- Restricted Diffusion Commit
rPf2f168cceb22: [Redesign] Use status icons in Maniphest task list
Look at a list of open and closed tasks, see icons match state (duplicate, spite, defaults).
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mani-icons
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 7068 Build 7189: [Placeholder Plan] Wait for 30 Seconds Build 7188: arc lint + arc unit
Event Timeline
| src/applications/maniphest/view/ManiphestTaskListView.php | ||
|---|---|---|
| 81 | You can end up with the "grey" class twice, but that's probably okay. Otherwise, you could re-factor to something like this $color = idx($color_map, $task->getPriority(), 'grey');
if ($task->isClosed()) {
$item->setDisabled(true);
$color = 'grey';
}
$icon .= ' '.$color; | |