Page MenuHomePhabricator
Differential D13487

[Redesign] Fix Maniphest subpriority editing
ClosedPublic
Actions

Authored by chad on Jun 30 2015, 4:32 PM.
Tags
None
Referenced Files
F14077287: D13487.diff
Thu, Nov 21, 10:25 PM
F14074532: D13487.diff
Thu, Nov 21, 7:36 AM
Unknown Object (File)
Wed, Nov 20, 4:19 PM
Unknown Object (File)
Thu, Nov 14, 6:44 AM
Unknown Object (File)
Wed, Oct 30, 7:28 PM
Unknown Object (File)
Tue, Oct 29, 12:57 AM
Unknown Object (File)
Wed, Oct 23, 12:23 PM
Unknown Object (File)
Oct 3 2024, 9:57 PM
View All Files
Subscribers
epriestley
• GoogleLegacy
Korvin
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
T8338: Unable to re-arrange Maniphest tasks into 1st row when dragging (redesign branch)
Commits
Restricted Diffusion Commit
rP2c922ca2306f: [Redesign] Fix Maniphest subpriority editing
Summary

Ref T8099, Fixes T8338. This allows re-ordering of Maniphest Tasks in the redesign. Somehow seems more fragile, but I couldn't break anything with it.

Test Plan

Try ordering into first position after header, last position, changing priority outright, everything I can drag.

Diff Detail

Repository
rP Phabricator
Branch
maniphest-ordering
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7064
Build 7181: [Placeholder Plan] Wait for 30 Seconds
Build 7180: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32629.Jun 30 2015, 4:32 PM
chad retitled this revision from to [Redesign] Fix Maniphest subpriority editing.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added tasks: T8338: Unable to re-arrange Maniphest tasks into 1st row when dragging (redesign branch), T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 30 2015, 4:32 PM
epriestley accepted this revision.Jun 30 2015, 4:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 30 2015, 4:36 PM
Closed by commit rP2c922ca2306f: [Redesign] Fix Maniphest subpriority editing (authored by chad, committed by chad). · Explain WhyJun 30 2015, 4:37 PM
This revision was automatically updated to reflect the committed changes.
btrahan awarded a token.Jun 30 2015, 6:14 PM
• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 9:36 AM
This comment was removed by epriestley.
• GoogleLegacy added a comment.Sep 10 2018, 9:37 AM
This comment was removed by epriestley.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
applications/
maniphest/
view/
2 lines
webroot/
rsrc/
js/
application/
maniphest/
6 lines

Diff 32629

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/view/ManiphestTaskResultListView.php

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-subpriorityeditor.js

Loading...
Phabricator · Built by Phacility