Paths

Table of Contentst

Differential D13463

[Redesign] Clean up AphrontDialog
ClosedPublic
Actions

Authored by chad on Jun 27 2015, 6:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 12, 12:45 AM

	Unknown Object (File)
	Thu, Dec 12, 12:41 AM

	Unknown Object (File)
	Tue, Dec 10, 7:04 AM

	Unknown Object (File)
	Thu, Dec 5, 4:39 AM

	Unknown Object (File)
	Wed, Nov 27, 11:35 AM

	Unknown Object (File)
	Tue, Nov 26, 10:50 PM

	Unknown Object (File)
	Mon, Nov 25, 7:49 PM

	Unknown Object (File)
	Mon, Nov 25, 7:49 PM

Subscribers

Tokens

"Love" token, awarded by epriestley.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP626c7bc9066f: [Redesign] Clean up AphrontDialog

Summary

Ref T8099, Cleans up UI issues, adds appendList and renders lists and paragraphs with Remarkup UI.

Test Plan

Test Policy Dialogs, other various dialogs.

Diff Detail

Repository

Branch

aphront-dialog

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7046
Build 7145: [Placeholder Plan] Wait for 30 Seconds
Build 7144: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32584.Jun 27 2015, 6:30 PM

chad retitled this revision from to [Redesign] Clean up AphrontDialog.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 27 2015, 6:30 PM

cool to land this?

epriestley requested changes to this revision.Jun 29 2015, 7:34 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
198	This may fatal, because this line is reachable without `$list` being defined.
src/applications/policy/controller/PhabricatorPolicyExplainController.php
49–50	This loop has no effect.
src/applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php
72–74	This may append an empty list, which is consistent with the old code but maybe not desirable.

This revision now requires changes to proceed.Jun 29 2015, 7:34 PM

done

epriestley accepted this revision.Jun 29 2015, 7:48 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php
72	Or just `if ($list)`

This revision is now accepted and ready to land.Jun 29 2015, 7:48 PM

Closed by commit rP626c7bc9066f: [Redesign] Clean up AphrontDialog (authored by chad, committed by chad). · Explain WhyJun 29 2015, 7:49 PM

This revision was automatically updated to reflect the committed changes.

(This was the only functional thing I've bumped into in the redesign recently.)

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

aphront/

configuration/

AphrontDefaultApplicationConfiguration.php

11 lines

applications/

policy/

controller/

PhabricatorPolicyExplainController.php

12 lines

transactions/

response/

PhabricatorApplicationTransactionNoEffectResponse.php

9 lines

PhabricatorApplicationTransactionValidationResponse.php

7 lines

view/

AphrontDialogView.php

21 lines

webroot/

rsrc/

css/

aphront/

dialog-view.css

8 lines

Diff 32604

resources/celerity/map.php

Loading...

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

Loading...

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Loading...

src/applications/transactions/response/PhabricatorApplicationTransactionNoEffectResponse.php

Loading...

src/applications/transactions/response/PhabricatorApplicationTransactionValidationResponse.php

Loading...

src/view/AphrontDialogView.php

Loading...

webroot/rsrc/css/aphront/dialog-view.css

Loading...