Page MenuHomePhabricator
Differential D13471

[Redesign] Remove AphrontTable restriction on Search Engine
ClosedPublic
Actions

Authored by chad on Jun 29 2015, 6:43 PM.
Tags
None
Referenced Files
F13190777: D13471.id32598.diff
Sat, May 11, 1:35 PM
F13182783: D13471.id32602.diff
Fri, May 10, 3:07 AM
F13177929: D13471.id32598.diff
Wed, May 8, 8:03 PM
Unknown Object (File)
Tue, May 7, 7:15 AM
Unknown Object (File)
Fri, May 3, 5:35 AM
Unknown Object (File)
Wed, May 1, 6:58 PM
Unknown Object (File)
Sun, Apr 28, 4:54 PM
Unknown Object (File)
Thu, Apr 25, 12:56 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rP08ec0f1704d9: [Redesign] Remove AphrontTable restriction on Search Engine
Summary

Ref T8099, functionally I prefer to be able to set anything 'table-like' with setTable for design consistency. This looses the restriction and did some light grepping for other missed cases.

Test Plan

Test new UI, grep for other missing cases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 32598.Jun 29 2015, 6:43 PM
chad retitled this revision from to [Redesign] Remove AphrontTable restriction on Search Engine.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 29 2015, 6:43 PM
epriestley accepted this revision.Jun 29 2015, 7:04 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2015, 7:04 PM
Closed by commit rP08ec0f1704d9: [Redesign] Remove AphrontTable restriction on Search Engine (authored by chad, committed by chad). · Explain WhyJun 29 2015, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32602

View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterUnitMessagesController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
View Options

src/applications/search/view/PhabricatorApplicationSearchResultView.php

Loading...
Phabricator · Built by Phacility