Page MenuHomePhabricator

[Redesign] Remove AphrontTable restriction on Search Engine
ClosedPublic

Authored by chad on Jun 29 2015, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 8:36 AM
Unknown Object (File)
Thu, Dec 5, 4:40 AM
Unknown Object (File)
Mon, Nov 25, 7:51 PM
Unknown Object (File)
Mon, Nov 25, 7:20 AM
Unknown Object (File)
Nov 19 2024, 6:46 AM
Unknown Object (File)
Nov 15 2024, 8:47 AM
Unknown Object (File)
Nov 11 2024, 7:54 AM
Unknown Object (File)
Nov 9 2024, 11:12 PM
Subscribers

Details

Summary

Ref T8099, functionally I prefer to be able to set anything 'table-like' with setTable for design consistency. This looses the restriction and did some light grepping for other missed cases.

Test Plan

Test new UI, grep for other missing cases.

Diff Detail

Repository
rP Phabricator
Branch
table
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7043
Build 7139: [Placeholder Plan] Wait for 30 Seconds
Build 7138: arc lint + arc unit

Event Timeline

chad retitled this revision from to [Redesign] Remove AphrontTable restriction on Search Engine.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2015, 7:04 PM
This revision was automatically updated to reflect the committed changes.