Differential D13469

Modernize transaction comment editor
ClosedPublic
Actions

Authored by epriestley on Jun 29 2015, 1:38 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8703: Unable to edit macro comments

Commits

Restricted Diffusion Commit
rPb39f5d651c42: Modernize transaction comment editor

Summary

Fixes T8703. The URI handling here was a little unusual.

Test Plan

Edited and deleted comments in several applications, including Macro.
As an admin, deleted others' comments.

Diff Detail

Repository

rP Phabricator

Branch

mcomment

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7041
Build 7135: [Placeholder Plan] Wait for 30 Seconds
Build 7134: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32593.Jun 29 2015, 1:38 PM

epriestley retitled this revision from to Modernize transaction comment editor.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8703: Unable to edit macro comments.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2015, 1:38 PM

btrahan accepted this revision.Jun 29 2015, 6:04 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 29 2015, 6:04 PM

Closed by commit rPb39f5d651c42: Modernize transaction comment editor (authored by epriestley, committed by epriestley). · Explain WhyJun 29 2015, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

controller/

PhabricatorApplicationTransactionCommentEditController.php

54 lines

Diff 32593

View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php

Modernize transaction comment editorClosedPublicActions