Page MenuHomePhabricator
Differential D13444

Provide phutil_json_encode()
ClosedPublic
Actions

Authored by epriestley on Jun 25 2015, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 13, 6:16 PM
Unknown Object (File)
Mon, Oct 7, 1:34 AM
Unknown Object (File)
Wed, Oct 2, 2:09 AM
Unknown Object (File)
Wed, Sep 25, 6:39 AM
Unknown Object (File)
Fri, Sep 20, 5:39 PM
Unknown Object (File)
Fri, Sep 20, 2:39 PM
Unknown Object (File)
Fri, Sep 20, 2:37 PM
Unknown Object (File)
Fri, Sep 20, 2:36 PM
View All Files
Subscribers
epriestley
Tokens
"Like" token, awarded by shrinidhirao.

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T8672: PhabricatorTaskmasterDaemon fatals in PublishWorker
Commits
rPHU3753a09dfc7e: Provide phutil_json_encode()
Summary

Ref T8672. Various issues like T8672 and T5955 are more difficult to understand and debug because we are not careful about checking for JSON encoding errors.

Add an error checking JSON encoder. This will let us raise an issue at the source of the problem, instead of further down the pipeline.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
json1
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1187XHP45PHP Compatibility
Errorsrc/utils/utils.php:1187XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 7013
Build 7081: [Placeholder Plan] Wait for 30 Seconds
Build 7080: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 32543.Jun 25 2015, 5:56 PM
epriestley retitled this revision from to Provide phutil_json_encode().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T8672: PhabricatorTaskmasterDaemon fatals in PublishWorker.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2015, 5:56 PM
btrahan accepted this revision.Jun 25 2015, 7:44 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 7:44 PM
joshuaspence edited edge metadata.Jun 25 2015, 10:04 PM

Feel free to land this without me, but I'd like to take a look probably tomorrow.

epriestley added a comment.Jun 25 2015, 10:04 PM

I'm probably going to wait until I promote to stable to get serious about this.

Closed by commit rPHU3753a09dfc7e: Provide phutil_json_encode() (authored by epriestley, committed by epriestley). · Explain WhyJul 7 2015, 12:55 PM
This revision was automatically updated to reflect the committed changes.
shrinidhirao awarded a token.Jul 7 2015, 2:50 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
utils/
__tests__/
15 lines
113 lines

Diff 32543

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility