Page MenuHomePhabricator
Differential D13434

[Redesign] Fix Maniphest closed header tags
ClosedPublic
Actions

Authored by chad on Jun 25 2015, 1:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 9:36 PM
Unknown Object (File)
Tue, Dec 10, 11:31 AM
Unknown Object (File)
Mon, Dec 9, 7:43 PM
Unknown Object (File)
Sun, Dec 8, 10:40 PM
Unknown Object (File)
Thu, Dec 5, 4:36 AM
Unknown Object (File)
Thu, Nov 28, 11:58 AM
Unknown Object (File)
Mon, Nov 25, 7:49 PM
Unknown Object (File)
Nov 24 2024, 9:57 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rPf8755ff8a4e1: [Redesign] Fix Maniphest closed header tags
Summary

Ref T8099, Fixes padding and spacing when status tags are coming from Maniphest. Also, maybe remove this?

Test Plan

Test closed tasks in Maniphest.

Diff Detail

Repository
rP Phabricator
Branch
maniphest-header
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7003
Build 7061: [Placeholder Plan] Wait for 30 Seconds
Build 7060: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 32521.Jun 25 2015, 1:51 PM
chad retitled this revision from to [Redesign] Fix Maniphest closed header tags.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 25 2015, 1:51 PM
epriestley accepted this revision.Jun 25 2015, 1:53 PM
epriestley edited edge metadata.

Also, maybe remove this?

Remove the status tag entirely?

This revision is now accepted and ready to land.Jun 25 2015, 1:53 PM
chad added a comment.Jun 25 2015, 1:54 PM

Seems in Differential and Maniphest, we have custom renderers (renderFullDescription) in Constants, but none of the rendering seems specifically unique.

Closed by commit rPf8755ff8a4e1: [Redesign] Fix Maniphest closed header tags (authored by chad, committed by chad). · Explain WhyJun 25 2015, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
constants/
2 lines

Diff 32521

View Options

src/applications/maniphest/constants/ManiphestTaskStatus.php

Loading...
Phabricator · Built by Phacility