Page MenuHomePhabricator
Differential D13399

[Redesign] Normalize header policy and object tags
ClosedPublic
Actions

Authored by chad on Jun 23 2015, 11:02 AM.
Tags
None
Referenced Files
F13281526: D13399.diff
Sun, Jun 2, 10:53 AM
F13271480: D13399.diff
Thu, May 30, 12:14 AM
F13255867: D13399.diff
Sat, May 25, 9:01 AM
F13250847: D13399.id32442.diff
Fri, May 24, 5:56 PM
F13205130: D13399.diff
Wed, May 15, 1:28 AM
F13198575: D13399.id32441.diff
Mon, May 13, 8:01 AM
F13196221: D13399.id32442.diff
Sun, May 12, 11:05 PM
F13188469: D13399.diff
Sat, May 11, 5:16 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T8099: Mid-2015 Phabricator Redesign
Commits
Restricted Diffusion Commit
rPd27b3146d25a: [Redesign] Normalize header policy and object tags
Summary

Ref T8099, This adds a consistent background color to object and policy tags, and highlights them when they deviate from the normal. Still likely worth revamping 'closed' and 'review' state colors.

Test Plan

Review lots of diffs and tasks.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 32441.Jun 23 2015, 11:02 AM
chad retitled this revision from to [Redesign] Normalize header policy and object tags.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T8099: Mid-2015 Phabricator Redesign.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 23 2015, 11:02 AM
epriestley accepted this revision.Jun 23 2015, 11:03 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2015, 11:03 AM
Closed by commit rPd27b3146d25a: [Redesign] Normalize header policy and object tags (authored by chad, committed by chad). · Explain WhyJun 23 2015, 11:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
differential/
constants/
2 lines
view/
phui/
2 lines
webroot/
rsrc/
css/
phui/
32 lines

Diff 32442

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility