MetaMTA - save actorPHID as its own column
ClosedPublic
Actions

Authored by btrahan on Jun 22 2015, 9:10 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5791: Write Herald rules for outbound mail

Commits

Restricted Diffusion Commit
rP4be568d34611: MetaMTA - save actorPHID as its own column

Summary

Ref T5791. This should make performance snappy wrt policy checks in some future diff where the Query is updated and in use somewhere in the application.

Test Plan

ran ./bin/storage upgrade. commented on a task and saw actorPHID populated correctly in underlying MetaMTAMail object database entry

Diff Detail

Repository

rP Phabricator

Branch

T5791

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6948
Build 6970: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 32436.Jun 22 2015, 9:10 PM

btrahan added a task: T5791: Write Herald rules for outbound mail.

btrahan retitled this revision from to MetaMTA - save actorPHID as its own column.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 22 2015, 9:10 PM

epriestley accepted this revision.Jun 22 2015, 9:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2015, 9:12 PM

epriestley awarded a token.Jun 22 2015, 9:12 PM

Closed by commit rP4be568d34611: MetaMTA - save actorPHID as its own column (authored by btrahan, committed by btrahan). · Explain WhyJun 22 2015, 9:13 PM

This revision was automatically updated to reflect the committed changes.

Not sure if these sorts of things are placed anywhere special these days but the application of this patch was brutal on our system -- took like 30 minutes on our relatively-decent hardware and MySQL instance. Might be worth warning.