Differential D13369

[Redesign] Provide more color to object states in headers
ClosedPublic
Actions

Authored by chad on Jun 20 2015, 9:13 PM.

Tags

None

Referenced Files

	F13972967: D13369.id.diff
	Oct 17 2024, 10:07 PM

	F13959700: D13369.id32384.diff
	Oct 14 2024, 8:21 PM

	Unknown Object (File)
	Oct 8 2024, 2:45 AM

	Unknown Object (File)
	Oct 5 2024, 3:06 PM

	Unknown Object (File)
	Sep 10 2024, 12:06 AM

	Unknown Object (File)
	Sep 2 2024, 11:55 AM

	Unknown Object (File)
	Sep 1 2024, 5:48 AM

	Unknown Object (File)
	Aug 27 2024, 7:23 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rPeba1153e7e07: [Redesign] Provide more color to object states in headers

Summary

Ref T8099, Now that we have cleaner headers, we can add more pop to important items, like the state of an Object. This makes it easier to just note the color and generally understand the state of the object (closed, returned, accepted, open). @epriestley, I think you previously thought this was a bug, but if it still feels bad, let me know.

Test Plan

Review Differential, Maniphest, Polls for various object states.

Screen Shot 2015-06-20 at 10.07.38 PM.png (260×560 px, 32 KB)

Diff Detail

Repository

Branch

header-closed

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6904
Build 6926: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 32366.Jun 20 2015, 9:13 PM

chad retitled this revision from to [Redesign] Provide more color to object states in headers.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T8099: Mid-2015 Phabricator Redesign.

chad added a subscriber: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 20 2015, 9:13 PM

chad edited the test plan for this revision. (Show Details)Jun 20 2015, 9:13 PM

IIRC the font/padding/alignment was a bit off for me before, this looks intentional (and good) to me now.

This revision is now accepted and ready to land.Jun 21 2015, 11:51 AM

Closed by commit rPeba1153e7e07: [Redesign] Provide more color to object states in headers (authored by chad, committed by chad). · Explain WhyJun 21 2015, 12:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

applications/

differential/

constants/

DifferentialRevisionStatus.php

6 lines

webroot/

rsrc/

css/

phui/

phui-header-view.css

13 lines

Diff 32366

resources/celerity/map.php

Loading...

src/applications/differential/constants/DifferentialRevisionStatus.php

Loading...

webroot/rsrc/css/phui/phui-header-view.css

Loading...