Replace Harbormaster "BuildItem" with Lint/Unit messages
ClosedPublic
Actions

Authored by epriestley on Jun 17 2015, 2:30 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8095: Let Harbormaster own Lint and Unit results

Commits

Restricted Diffusion Commit
rP7ad4c9c056d1: Replace Harbormaster "BuildItem" with Lint/Unit messages

Summary

Ref T8095.

Harbormaster has a BuildItem class, but it has no table and is unused. This was an earlier idea about representing lint/unit results and some other possible types of messages, but I think we want to be more specific than this.

Remove BuildItem and add Lint and Unit storage. These tables roughly parallel how we store lint/unit messages today, with some guesses about how where they'll go in the future.

Test Plan

Ran bin/storage upgrade and got a clean adjust out of it.

Diff Detail

Repository

rP Phabricator

Branch

plan1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6828
Build 6850: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32249.Jun 17 2015, 2:30 PM

epriestley retitled this revision from to Replace Harbormaster "BuildItem" with Lint/Unit messages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 17 2015, 2:30 PM

btrahan accepted this revision.Jun 17 2015, 10:31 PM

btrahan edited edge metadata.

btrahan added inline comments.

resources/sql/autopatches/20150617.harbor.1.lint.sql
7–8	Depending on how much re-design wiggle room you have here, perhaps "code" can also encompass "severity"?

This revision is now accepted and ready to land.Jun 17 2015, 10:31 PM

For reference, this will conflict with D11692, which will need to be updated to use these new storage classes.

Closed by commit rP7ad4c9c056d1: Replace Harbormaster "BuildItem" with Lint/Unit messages (authored by epriestley, committed by epriestley). · Explain WhyJun 21 2015, 4:00 PM

This revision was automatically updated to reflect the committed changes.

I think it's desirable that "severity" remain separate from "code". In some projects a message with the same code (say, something like some sort of whitespace issue) might be a "warning", while in others it might only be "advice". It seems reasonable to let projects configure how much they care about each kind of issue lint can raise.