Page MenuHomePhabricator

Replace Harbormaster "BuildItem" with Lint/Unit messages
ClosedPublic

Authored by epriestley on Jun 17 2015, 2:30 PM.
Tags
None
Referenced Files
F15418741: D13329.id.diff
Fri, Mar 21, 1:10 AM
F15418070: D13329.id32249.diff
Thu, Mar 20, 8:38 PM
F15414207: D13329.diff
Wed, Mar 19, 11:23 PM
F15399808: D13329.id32249.diff
Mon, Mar 17, 7:51 AM
F15399003: D13329.diff
Mon, Mar 17, 2:23 AM
F15366139: D13329.id32386.diff
Tue, Mar 11, 2:28 PM
Unknown Object (File)
Feb 8 2025, 11:49 AM
Unknown Object (File)
Feb 8 2025, 11:49 AM

Details

Summary

Ref T8095.

Harbormaster has a BuildItem class, but it has no table and is unused. This was an earlier idea about representing lint/unit results and some other possible types of messages, but I think we want to be more specific than this.

Remove BuildItem and add Lint and Unit storage. These tables roughly parallel how we store lint/unit messages today, with some guesses about how where they'll go in the future.

Test Plan

Ran bin/storage upgrade and got a clean adjust out of it.

Diff Detail

Repository
rP Phabricator
Branch
plan1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6828
Build 6850: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Replace Harbormaster "BuildItem" with Lint/Unit messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
resources/sql/autopatches/20150617.harbor.1.lint.sql
7–8

Depending on how much re-design wiggle room you have here, perhaps "code" can also encompass "severity"?

This revision is now accepted and ready to land.Jun 17 2015, 10:31 PM

For reference, this will conflict with D11692, which will need to be updated to use these new storage classes.

This revision was automatically updated to reflect the committed changes.

I think it's desirable that "severity" remain separate from "code". In some projects a message with the same code (say, something like some sort of whitespace issue) might be a "warning", while in others it might only be "advice". It seems reasonable to let projects configure how much they care about each kind of issue lint can raise.