Page MenuHomePhabricator

Fail gracefully on bad API call when building commit mail
ClosedPublic

Authored by epriestley on Jun 16 2015, 10:56 PM.
Tags
None
Referenced Files
F14482829: D13319.id32233.diff
Mon, Dec 30, 11:54 AM
F14481610: D13319.id32233.diff
Mon, Dec 30, 4:26 AM
Unknown Object (File)
Sat, Dec 21, 5:56 AM
Unknown Object (File)
Wed, Dec 4, 6:37 PM
Unknown Object (File)
Nov 27 2024, 12:02 AM
Unknown Object (File)
Nov 22 2024, 10:18 PM
Unknown Object (File)
Nov 20 2024, 7:03 AM
Unknown Object (File)
Nov 18 2024, 1:50 PM
Subscribers

Details

Summary

Ref T8574. This could fail because the target is disabled (as here), or doesn't have access to the API, or the API request needs to be satisfied by a different host which isn't available.

In any of these cases, just show the failure and continue generating the mail. This field isn't important enough to block the mail, and many of these errors are permanent.

(I'll follow up on T8574 with some more permanent ideas to address this class of issue.)

Test Plan

Faked API call failure, generated mail, saw clean generation of mail with a failure message.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fail gracefully on bad API call when building commit mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2015, 11:04 PM
This revision was automatically updated to reflect the committed changes.