Page MenuHomePhabricator

Mark some PhabricatorApplication methods as final
ClosedPublic

Authored by joshuaspence on Jun 13 2015, 12:36 AM.
Tags
None
Referenced Files
F13998825: D13265.id32112.diff
Thu, Oct 24, 11:23 AM
F13991081: D13265.id32112.diff
Tue, Oct 22, 8:41 AM
F13990882: D13265.id.diff
Tue, Oct 22, 7:01 AM
F13987820: D13265.diff
Mon, Oct 21, 11:30 AM
F13978728: D13265.id32114.diff
Sat, Oct 19, 12:41 AM
Unknown Object (File)
Oct 12 2024, 7:33 PM
Unknown Object (File)
Sep 29 2024, 10:33 AM
Unknown Object (File)
Sep 27 2024, 8:01 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP934285a6d3d2: Mark some PhabricatorApplication methods as final
Summary

I don't believe that any subclass should override these methods.

Test Plan

arc unit

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark some PhabricatorApplication methods as final.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I think it's plausible that a couple of these (like getApplicationURI() and isInstalled()) might eventually have some kind of use case, but we can add hooks or strip final if/when they do. Most of them seem unambiguously final.

This revision is now accepted and ready to land.Jun 13 2015, 3:52 PM
This revision was automatically updated to reflect the committed changes.