I don't believe that any subclass should override these methods.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP934285a6d3d2: Mark some PhabricatorApplication methods as final
arc unit
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 6748 Build 6770: [Placeholder Plan] Wait for 30 Seconds
| Time | Test | |
|---|---|---|
| 5,230 ms | PhabricatorLibraryTestCase::testMethodVisibility | |
| 764 ms | PhabricatorCelerityTestCase::testCelerityMaps | |
| 8 ms | PhabricatorConduitTestCase::testConduitMethods | |
| 0 ms | PhabricatorInfrastructureTestCase::testApplicationsInstalled | |
| 1 ms | PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries | |
| View Full Test Results (1 Failed · 6 Passed) |
Event Timeline
Comment Actions
I think it's plausible that a couple of these (like getApplicationURI() and isInstalled()) might eventually have some kind of use case, but we can add hooks or strip final if/when they do. Most of them seem unambiguously final.