Page MenuHomePhabricator
Differential D13273

Add some tests for subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jun 13 2015, 8:43 AM.
Tags
None
Referenced Files
F15342813: D13273.diff
Sun, Mar 9, 9:26 PM
F15340366: D13273.diff
Sun, Mar 9, 3:03 PM
F15333835: D13273.id32149.diff
Sat, Mar 8, 5:09 AM
Unknown Object (File)
Fri, Feb 14, 10:40 PM
Unknown Object (File)
Tue, Feb 11, 9:29 PM
Unknown Object (File)
Feb 8 2025, 10:04 AM
Unknown Object (File)
Feb 8 2025, 10:03 AM
Unknown Object (File)
Feb 8 2025, 10:03 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU0cff5de51378: Add some tests for subclasses
Summary

Add some tests to ensure that PhutilLocale and PhutilTranslation subclasses are properly implemented. See D13272 for a similar change.

Test Plan

arc unit

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6724
Build 6746: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32072.Jun 13 2015, 8:43 AM
joshuaspence retitled this revision from to Add some tests.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2015, 8:43 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 13 2015, 3:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2015, 3:24 PM
joshuaspence retitled this revision from Add some tests to Add some tests for subclasses.Jun 15 2015, 8:05 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.
Closed by commit rPHU0cff5de51378: Add some tests for subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 15 2015, 8:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
internationalization/
__tests__/
10 lines
10 lines

Diff 32072

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/internationalization/__tests__/PhutilLocaleTestCase.php

Loading...
View Options

src/internationalization/__tests__/PhutilTranslationTestCase.php

Loading...
Phabricator · Built by Phacility