Page MenuHomePhabricator
Differential D13267

Remove backticks from SQL statements
ClosedPublic
Actions

Authored by joshuaspence on Jun 13 2015, 4:06 AM.
Tags
None
Referenced Files
F14742549: D13267.id32064.diff
Mon, Jan 20, 10:54 AM
Unknown Object (File)
Sat, Dec 28, 2:18 PM
Unknown Object (File)
Thu, Dec 26, 7:13 AM
Unknown Object (File)
Dec 8 2024, 7:54 AM
Unknown Object (File)
Dec 7 2024, 12:02 PM
Unknown Object (File)
Dec 6 2024, 4:55 AM
Unknown Object (File)
Nov 28 2024, 1:45 AM
Unknown Object (File)
Nov 27 2024, 11:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
eadler
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP070da8286407: Remove backticks from SQL statements
Summary

Remove backticks from SQL statements for consistency. In most places, we don't use backticks around table/field names, so at least be consistent about this.

Test Plan

Learned what backticks are used for in MySQL.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6716
Build 6738: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 32064.Jun 13 2015, 4:06 AM
joshuaspence retitled this revision from to Remove backticks from SQL statements.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 13 2015, 4:06 AM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 13 2015, 3:22 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Jun 13 2015, 3:22 PM
eadler accepted this revision.Jun 14 2015, 6:23 AM
eadler added a reviewer: eadler.
joshuaspence updated this object.Jun 14 2015, 9:37 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
Closed by commit rP070da8286407: Remove backticks from SQL statements (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 14 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
garbagecollector/
2 lines
ponder/
editor/
4 lines
xhprof/
controller/
6 lines

Diff 32064

View Options

src/applications/herald/garbagecollector/HeraldTranscriptGarbageCollector.php

Loading...
View Options

src/applications/ponder/editor/PonderVoteEditor.php

Loading...
View Options

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php

Loading...
Phabricator · Built by Phacility