Ref T8493. Add Spaces support to Pholio.
This is straightforward; Pholio has no clone/copy/fork or weird parent/child stuff going on.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T8493: Integrate Spaces into more applications
- Commits
- Restricted Diffusion Commit
rPde0e0d995baa: Support Spaces in Pholio
Created a mock, put it in a space, looked at it as another user, searched for stuff in spaces, viewed Macros.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- aspace2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6654 Build 6676: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Just double checking the images that comprise a mock are also "space'd" properly by this change.
| src/applications/pholio/storage/PholioMock.php | ||
|---|---|---|
| 32 | do these images end up being in the space as well? e.g. user makes a mock with N images ...the N images are also in the space with respect to viewability? | |
Comment Actions
the N images are also in the space with respect to viewability
Yeah, we generally get this automatically: when you load an image, we also load and attach the mock. If you can't see the mock, we filter out the image. So moving a mock to a space you can't see is sufficient to hide the image, as well, for the same reason that setting the mock to "visible to: only me" is also sufficient to hide the image.
(If some future diff let you interact directly with images that a different viewer might have loaded [for example, we let you write Herald rules directly against Images or something], we'd need to implement PhabricatorExtendedPolicyInterface to avoid T7703, but there's no way to hit that currently and I don't anticipate adding one any time soon / ever.)