Differential D13217

Fix an issue with adding or updating images in unified diff view
ClosedPublic
Actions

Authored by epriestley on Jun 8 2015, 10:07 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage()

Commits

Restricted Diffusion Commit
rP929f5f22acef: Fix an issue with adding or updating images in unified diff view

Summary

Fixes T8069.

Test Plan

Viewed a new image in unified diff view.

Diff Detail

Repository

rP Phabricator

Branch

imagestage

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6636
Build 6658: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31951.Jun 8 2015, 10:07 PM

epriestley retitled this revision from to Fix an issue with adding or updating images in unified diff view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage().

Herald added a subscriber: epriestley. · View Herald TranscriptJun 8 2015, 10:07 PM

btrahan accepted this revision.Jun 8 2015, 10:39 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 10:39 PM

Closed by commit rP929f5f22acef: Fix an issue with adding or updating images in unified diff view (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 10:40 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence awarded a token.Jun 8 2015, 11:01 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

2 lines

Diff 31951

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Fix an issue with adding or updating images in unified diff viewClosedPublicActions