Page MenuHomePhabricator

Mark some strings for translation
ClosedPublic

Authored by joshuaspence on Jun 8 2015, 8:16 AM.
Tags
None
Referenced Files
F14018237: D13199.id31945.diff
Tue, Nov 5, 6:45 AM
F14018109: D13199.diff
Tue, Nov 5, 4:51 AM
F14013904: D13199.id31901.diff
Sat, Nov 2, 7:01 PM
F14009171: D13199.id31946.diff
Wed, Oct 30, 11:42 AM
F13985853: D13199.diff
Sun, Oct 20, 11:15 PM
F13980616: D13199.diff
Sat, Oct 19, 11:39 AM
F13969028: D13199.id31901.diff
Thu, Oct 17, 12:06 AM
F13965508: D13199.diff
Wed, Oct 16, 2:29 AM
Subscribers

Details

Summary

Add some more phtizations.

Test Plan

Eyeball it.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Mark some strings for translation.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
src/error/PhutilErrorHandler.php
423–425 ↗(On Diff #31901)

Possibly pht might not be defined at this point I suspect? If so, we could do something like this:

if (function_exists('pht')) {
  $err_str = pht(
    'Error handler was reentered, some errors were not passed to the '.
    'listener.');
} else {
  $err_str = 
    'Error handler was reentered, some errors were not passed to the '.
    'listener.';
}

error_log($err_str);
epriestley edited edge metadata.
epriestley added inline comments.
src/error/PhutilErrorHandler.php
423–425 ↗(On Diff #31901)

I don't think we should translate this, because of the potential to recurse indefinitely if the error is in pht() itself.

That seems worse/more dangerous than a Spanish developer getting one English error message after already hitting a double-bad error.

This revision is now accepted and ready to land.Jun 8 2015, 8:56 PM
joshuaspence edited edge metadata.

Remove changes to PhutilErrorHandler

This revision was automatically updated to reflect the committed changes.