Add some more phtizations.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHU92882eb9404d: Mark some strings for translation
Eyeball it.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6632 Build 6654: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
src/error/PhutilErrorHandler.php | ||
---|---|---|
423–425 ↗ | (On Diff #31901) | Possibly pht might not be defined at this point I suspect? If so, we could do something like this: if (function_exists('pht')) { $err_str = pht( 'Error handler was reentered, some errors were not passed to the '. 'listener.'); } else { $err_str = 'Error handler was reentered, some errors were not passed to the '. 'listener.'; } error_log($err_str); |
src/error/PhutilErrorHandler.php | ||
---|---|---|
423–425 ↗ | (On Diff #31901) | I don't think we should translate this, because of the potential to recurse indefinitely if the error is in pht() itself. That seems worse/more dangerous than a Spanish developer getting one English error message after already hitting a double-bad error. |