Page MenuHomePhabricator
Differential D13205

Fix an issue with extended policy checks and `@mentions`
ClosedPublic
Actions

Authored by epriestley on Jun 8 2015, 1:35 PM.
Tags
None
Referenced Files
F13258653: D13205.id31910.diff
Sun, May 26, 11:33 AM
F13244515: D13205.diff
Thu, May 23, 5:06 AM
F13220629: D13205.diff
Sun, May 19, 1:49 AM
F13209632: D13205.id31908.diff
Fri, May 17, 1:16 AM
F13203053: D13205.diff
Tue, May 14, 11:26 PM
F13199375: D13205.id.diff
Mon, May 13, 2:06 PM
F13186291: D13205.diff
Sat, May 11, 3:32 AM
Unknown Object (File)
Apr 30 2024, 11:20 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8463: Username `@mentions` prevent creation of revisions with "data not attached" error
Commits
Restricted Diffusion Commit
rP2e0f18995059: Fix an issue with extended policy checks and `@mentions`
Summary

Ref T8463.

Test Plan
  • Created a new revision via web UI with a username @mention in the summary and no repository.
  • Prior to patch, hit a "not attached" error.
  • After patch, no error.
  • Created a new web UI revision, as above, but with a repository; saw repository work fine.

Diff Detail

Repository
rP Phabricator
Branch
diff1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6623
Build 6645: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31908.Jun 8 2015, 1:35 PM
epriestley retitled this revision from to Fix an issue with extended policy checks and `@mentions`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 8 2015, 1:35 PM
epriestley mentioned this in T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.Jun 8 2015, 1:36 PM
btrahan accepted this revision.Jun 8 2015, 3:24 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 3:24 PM
Closed by commit rP2e0f18995059: Fix an issue with extended policy checks and `@mentions` (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
1 line

Diff 31908

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility