Paths

Table of Contentst

Differential D13201

Fix method visibilities
ClosedPublic
Actions

Authored by joshuaspence on Jun 8 2015, 8:40 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPaf1b586990a7: Fix method visibilities

Summary

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6619
Build 6641: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31904.Jun 8 2015, 8:40 AM

joshuaspence retitled this revision from to Fix method visibilities.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 8 2015, 8:40 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I miiiight have already fixed this in followups.

This revision is now accepted and ready to land.Jun 8 2015, 8:45 PM

Nope, looks like you made it worse :P

oh good

I am special

Rebase

wow I made it a lot worse

I'll try to finish off D13185 today (which is sort of okay as is, but I want to improve it after D13202 lands).

Closed by commit rPaf1b586990a7: Fix method visibilities (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 8 2015, 9:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

files/

query/

PhabricatorFileSearchEngine.php

2 lines

pholio/

query/

PholioMockSearchEngine.php

4 lines

Diff 31904

View Options

src/applications/files/query/PhabricatorFileSearchEngine.php