Revert "Simplify the use of `phutil_get_library_root`"
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2015, 11:00 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUa39e8ded1dbf: Revert "Simplify the use of `phutil_get_library_root`"

Summary

This reverts commit 67a17d0efb025665237d0d174d55d1887f9a6064.

This doesn't actually work because the call to phutil_get_current_library_name() always occurs within libphutil.

Test Plan

N/A

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6598
Build 6620: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31871.Jun 7 2015, 11:00 AM

joshuaspence retitled this revision from to Revert "Simplify the use of `phutil_get_library_root`".

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2015, 11:00 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 7 2015, 1:30 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2015, 1:30 PM

Closed by commit rPHUa39e8ded1dbf: Revert "Simplify the use of `phutil_get_library_root`" (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 7 2015, 11:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

moduleutils.php

5 lines

Diff 31871

View Options

src/moduleutils/moduleutils.php

Revert "Simplify the use of `phutil_get_library_root`"ClosedPublicActions