Page MenuHomePhabricator

Use standard subscribers effects in Herald Adapter for commits
ClosedPublic

Authored by epriestley on Jun 6 2015, 12:49 PM.
Tags
None
Referenced Files
F14830600: D13181.id31861.diff
Wed, Jan 29, 9:40 PM
Unknown Object (File)
Sat, Jan 25, 4:44 AM
Unknown Object (File)
Fri, Jan 24, 6:01 AM
Unknown Object (File)
Fri, Jan 24, 6:00 AM
Unknown Object (File)
Fri, Jan 24, 6:00 AM
Unknown Object (File)
Thu, Jan 23, 10:13 PM
Unknown Object (File)
Tue, Jan 21, 3:15 PM
Unknown Object (File)
Tue, Jan 21, 12:56 PM
Subscribers

Details

Summary

Ref T8455. Use the standard actions in commit rules, instead of a custom action.

Test Plan

Wrote an "add cc" Herald rule for commits, pushed a commit, saw the rule fire correctly.

Diff Detail

Repository
rP Phabricator
Branch
hcc5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6590
Build 6612: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use standard subscribers effects in Herald Adapter for commits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 4:59 PM
This revision was automatically updated to reflect the committed changes.