Differential D13181

Use standard subscribers effects in Herald Adapter for commits
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 12:49 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T8455: Herald rules with mailing lists are broken after mailing list -> user migration

Commits

Restricted Diffusion Commit
rPab5f7a868e01: Use standard subscribers effects in Herald Adapter for commits

Summary

Ref T8455. Use the standard actions in commit rules, instead of a custom action.

Test Plan

Wrote an "add cc" Herald rule for commits, pushed a commit, saw the rule fire correctly.

Diff Detail

Repository

rP Phabricator

Branch

hcc5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6590
Build 6612: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31861.Jun 6 2015, 12:49 PM

epriestley retitled this revision from to Use standard subscribers effects in Herald Adapter for commits.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 6 2015, 12:49 PM

btrahan accepted this revision.Jun 8 2015, 4:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 4:59 PM

Closed by commit rPab5f7a868e01: Use standard subscribers effects in Herald Adapter for commits (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

10 lines

herald/

adapter/

HeraldCommitAdapter.php

19 lines

Diff 31861

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php