Page MenuHomePhabricator
Differential D13180

Use standard subscribers effects in Herald Adapter for Phriction
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 4:20 AM
Unknown Object (File)
Mon, Dec 2, 8:46 PM
Unknown Object (File)
Fri, Nov 29, 10:34 AM
Unknown Object (File)
Wed, Nov 27, 4:25 PM
Unknown Object (File)
Nov 19 2024, 9:57 AM
Unknown Object (File)
Nov 11 2024, 8:03 PM
Unknown Object (File)
Nov 9 2024, 9:17 AM
Unknown Object (File)
Nov 9 2024, 9:17 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8455: Herald rules with mailing lists are broken after mailing list -> user migration
Commits
Restricted Diffusion Commit
rPe2b0f814d471: Use standard subscribers effects in Herald Adapter for Phriction
Summary

Ref T8455. Instead of using an ad-hoc subscribers effect in Phriction, use the new standard one (introduced previously; this depends on D13178).

Test Plan
  • Wrote an "add subscribers" Herald rule, updated a Phriction document, saw it apply its effect.
  • Observed availability of "remove" subscribers actions.

Diff Detail

Repository
rP Phabricator
Branch
hcc4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6589
Build 6611: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31860.Jun 6 2015, 12:40 PM
epriestley retitled this revision from to Use standard subscribers effects in Herald Adapter for Phriction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8455: Herald rules with mailing lists are broken after mailing list -> user migration.
epriestley added a parent revision: D13178: Make ACTION_NOTHING a "standard" action in Herald.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 6 2015, 12:40 PM
btrahan accepted this revision.Jun 8 2015, 4:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 4:58 PM
Closed by commit rPe2b0f814d471: Use standard subscribers effects in Herald Adapter for Phriction (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
editor/
18 lines
herald/
30 lines

Diff 31860

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
View Options

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...
Phabricator · Built by Phacility