Ref T8455. Multiple adapters implement essentially identical effects for ACTION_NOTHING. Consolidate them.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T8455: Herald rules with mailing lists are broken after mailing list -> user migration
- Commits
- Restricted Diffusion Commit
rPce434e821c7b: Make ACTION_NOTHING a "standard" action in Herald
Created several ACTION_NOTHING rules and updated the corresponding objects.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hcc2
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6587 Build 6609: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
- Also consolidate the action on HeraldDifferentialDiffAdapter.
- Fix an issue on HeraldDifferentialDiffAdapter where the action name map wasn't built correctly, preventing the creation of "Do nothing" diff rules from the UI.
- Wrote and executed a "Do nothing" diff rule.