Page MenuHomePhabricator
Differential D13174

Move Pholio to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 10:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:44 PM
Unknown Object (File)
Fri, Dec 13, 12:44 PM
Unknown Object (File)
Fri, Dec 13, 12:44 PM
Unknown Object (File)
Fri, Dec 13, 12:00 AM
Unknown Object (File)
Thu, Dec 12, 5:43 AM
Unknown Object (File)
Sun, Dec 8, 10:18 AM
Unknown Object (File)
Sun, Dec 8, 12:13 AM
Unknown Object (File)
Sat, Dec 7, 7:16 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rP2492fef029b1: Move Pholio to SearchFields
Summary

Ref T8441. Ref T7715.

  • Update PholioSearchEngine.
  • Automatically add project fields.
  • Update Paste to support project search.
  • Simplify common Query class construction.
Test Plan
  • Searched for pastes.
  • Searched for mocks.

Diff Detail

Repository
rP Phabricator
Branch
spaces1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6580
Build 6602: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31850.Jun 5 2015, 10:23 PM
epriestley retitled this revision from to Move Pholio to SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 5 2015, 10:23 PM
btrahan accepted this revision.Jun 6 2015, 7:57 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2015, 7:57 PM
Closed by commit rP2492fef029b1: Move Pholio to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2015, 2:31 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in T8633: Modernize query engines.Jun 21 2015, 11:54 AM
joshuaspence mentioned this in T8634: Modernize search engines.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
paste/
query/
29 lines
pholio/
query/
33 lines
86 lines
storage/
9 lines
search/
engine/
15 lines
field/
40 lines
50 lines
infrastructure/
query/
policy/
18 lines

Diff 31850

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteQuery.php

Loading...
View Options

src/applications/pholio/query/PholioMockQuery.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/pholio/storage/PholioMock.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchCheckboxesField.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchProjectsField.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility