Page MenuHomePhabricator
Differential D13121

Cancelled recurring events should propogate to real child events
ClosedPublic
Actions

Authored by lpriestley on Jun 2 2015, 3:51 PM.
Tags
None
Referenced Files
F14054174: D13121.diff
Fri, Nov 15, 10:56 PM
F14052963: D13121.id31709.diff
Fri, Nov 15, 11:48 AM
F14050363: D13121.id31678.diff
Thu, Nov 14, 6:06 PM
F14048393: D13121.id31706.diff
Thu, Nov 14, 7:40 AM
F14048392: D13121.id31679.diff
Thu, Nov 14, 7:40 AM
F14048391: D13121.id31677.diff
Thu, Nov 14, 7:40 AM
F14048390: D13121.id31709.diff
Thu, Nov 14, 7:40 AM
F14048389: D13121.id31705.diff
Thu, Nov 14, 7:40 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8371: Canceling a recurrence should soft-cancel all exceptions to the recurrence.
Commits
Restricted Diffusion Commit
rP446611e2e323: Cancelled recurring events should propogate to real child events
Summary

Ref T8371, Cancelled recurring events should propogate to real child events

Test Plan

Create recurring event, create and exception to a ghost event, cancel recurring event, real ghost event should be treated as cancelled while the recurring event remains cancelled.

Diff Detail

Repository
rP Phabricator
Branch
calendarcancelrecurring
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/calendar/query/PhabricatorCalendarEventQuery.php:124TXT3Line Too Long
Warningsrc/applications/calendar/query/PhabricatorCalendarEventQuery.php:339TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 6485
Build 6507: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 31677.Jun 2 2015, 3:51 PM
lpriestley retitled this revision from to Cancelled recurring events should propogate to real child events.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8371: Canceling a recurrence should soft-cancel all exceptions to the recurrence..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 3:51 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 31678.Jun 2 2015, 4:18 PM
lpriestley edited edge metadata.

Attempting to optimize getting parent events

lpriestley updated this revision to Diff 31679.EditedJun 2 2015, 4:23 PM

making use of lazy evaluation

lpriestley updated this revision to Diff 31680.Jun 2 2015, 4:33 PM

cleanup

lpriestley updated this revision to Diff 31699.Jun 2 2015, 11:58 PM

syncing most recent

lpriestley updated this revision to Diff 31703.Jun 3 2015, 1:31 AM

cleaning up lint complaints

lpriestley updated this revision to Diff 31704.Jun 3 2015, 1:44 AM

Ghost exceptions were not being unset before this.

lpriestley updated this revision to Diff 31705.Jun 3 2015, 2:02 AM

queries with no recurring events should not produce error.

lpriestley updated this revision to Diff 31706.Jun 3 2015, 2:17 AM

not filtering out ghost events.

lpriestley updated this revision to Diff 31707.Jun 3 2015, 2:38 AM

Fix problems with editing ghost events

lpriestley updated this revision to Diff 31708.Jun 3 2015, 2:40 AM

helpful comment

epriestley accepted this revision.Jun 3 2015, 2:42 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/storage/PhabricatorCalendarEvent.php
351–353

This is never possible -- we either have a parent event or this throws because one wasn't attached.

This revision is now accepted and ready to land.Jun 3 2015, 2:42 AM
lpriestley updated this revision to Diff 31709.Jun 3 2015, 2:43 AM
lpriestley edited edge metadata.

addressing code review

lpriestley marked an inline comment as done.Jun 3 2015, 2:43 AM
Closed by commit rP446611e2e323: Cancelled recurring events should propogate to real child events (authored by lpriestley, committed by lpriestley). · Explain WhyJun 3 2015, 2:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
query/
45 lines
storage/
30 lines

Diff 31699

View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility