Page MenuHomePhabricator

Canceling a recurrence should soft-cancel all exceptions to the recurrence.
Closed, ResolvedPublic

Description

When we load an event which is an instanceOfEventPHID, we can also load the original event and attach it. The we can do something like:

public function getIsCancelled() {
if ($this->getInstanceOfEventPHID() && $this->getOriginalEvent()->getIsCancelled()) { return true; }
return $this->isCancelled;
}

so as not to lose the cancellation state of an event when the parent recurrence is cancelled/reinstated.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision

Event Timeline

lpriestley claimed this task.
lpriestley raised the priority of this task from to Normal.
lpriestley updated the task description. (Show Details)
lpriestley added a project: Calendar.
lpriestley added a subscriber: lpriestley.
lpriestley added a revision: Restricted Differential Revision.Jun 2 2015, 3:51 PM
lpriestley added a commit: Restricted Diffusion Commit.Jun 3 2015, 2:44 AM

Add a withInstanceOfEventPHID(null) to query where we get parent events of recurring events, to avoid inter-dependent events.

lpriestley added a revision: Restricted Differential Revision.Jun 3 2015, 4:23 PM
lpriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jun 3 2015, 4:27 PM
lpriestley added a commit: Restricted Diffusion Commit.