Paths

Table of Contentst

Differential D13110

Tidy up ManiphestTask destruction
ClosedPublic
Actions

Authored by joshuaspence on Jun 2 2015, 10:16 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP2d15c3c06289: Tidy up ManiphestTask destruction

Summary

Now that ManiphestTask implements PhabricatorApplicationTransactionInterface, the transaction removal happens automatically.

Test Plan

Used ./bin/remove destroy to delete a ManiphestTask and saw related transactions removed as well.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6446
Build 6468: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 31650.Jun 2 2015, 10:16 AM

joshuaspence retitled this revision from to Tidy up ManiphestTask destruction.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 2 2015, 10:16 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jun 2 2015, 11:59 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 2 2015, 11:59 AM

Closed by commit rP2d15c3c06289: Tidy up ManiphestTask destruction (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 2 2015, 12:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTask.php

12 lines

Diff 31650

View Options

src/applications/maniphest/storage/ManiphestTask.php

Tidy up ManiphestTask destructionClosedPublicActions