Page MenuHomePhabricator
Differential D13103

Spaces - re-jigger application name for new Spaces application
ClosedPublic
Actions

Authored by btrahan on Jun 1 2015, 9:24 PM.
Tags
None
Referenced Files
F13167399: D13103.diff
Tue, May 7, 7:08 AM
Unknown Object (File)
Fri, May 3, 5:14 AM
Unknown Object (File)
Thu, Apr 25, 12:49 AM
Unknown Object (File)
Mon, Apr 8, 2:04 PM
Unknown Object (File)
Apr 1 2024, 10:56 PM
Unknown Object (File)
Apr 1 2024, 5:05 AM
Unknown Object (File)
Mar 31 2024, 8:20 PM
Unknown Object (File)
Mar 28 2024, 1:17 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8377: Build the core "Spaces" Application
Commits
Restricted Diffusion Commit
rPc83ddc3a0eb3: Spaces - re-jigger application name for new Spaces application
Summary

got some errors in my sandbox when I updated. this fixes them and I think is the right naming convention.

Test Plan

/settings/panel/emailpreferences/ started working again! /spaces/ also loaded unit tests passed without errors

Diff Detail

Repository
rP Phabricator
Branch
spaces
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6432
Build 6454: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31634.Jun 1 2015, 9:24 PM
btrahan retitled this revision from to Spaces - re-jigger application name for new Spaces application.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptJun 1 2015, 9:24 PM
btrahan added a task: T8377: Build the core "Spaces" Application.Jun 1 2015, 9:25 PM
epriestley accepted this revision.Jun 1 2015, 9:36 PM
epriestley edited edge metadata.

Ah, thanks!

This revision is now accepted and ready to land.Jun 1 2015, 9:36 PM
Closed by commit rPc83ddc3a0eb3: Spaces - re-jigger application name for new Spaces application (authored by btrahan, committed by btrahan). · Explain WhyJun 1 2015, 9:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
spaces/
application/
PhabricatorSpacesApplication.php
PhabricatorApplicationSpaces.php
2 lines
query/
2 lines
storage/
2 lines

Diff 31634

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/spaces/application/PhabricatorApplicationSpaces.php

Loading...
View Options

src/applications/spaces/application/PhabricatorSpacesApplication.php

Loading...
View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

Loading...
View Options

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

Loading...
Phabricator · Built by Phacility