Page MenuHomePhabricator

Prevent an error when the Drydock lease artifact does not exist
ClosedPublic

Authored by hach-que on May 30 2015, 12:38 PM.
Tags
None
Referenced Files
F13811928: D13074.diff
Wed, Sep 18, 8:42 AM
F13811026: D13074.diff
Tue, Sep 17, 11:40 PM
Unknown Object (File)
Mon, Sep 16, 1:55 PM
Unknown Object (File)
Mon, Sep 16, 10:21 AM
Unknown Object (File)
Mon, Sep 16, 1:57 AM
Unknown Object (File)
Wed, Sep 11, 4:08 AM
Unknown Object (File)
Sat, Aug 31, 5:38 AM
Unknown Object (File)
Wed, Aug 21, 8:05 AM

Details

Summary

If a host artifact exists in a Harbormaster build, where the Drydock lease no longer exists, then an error will be raised because of the attempt to access an undefined index. This changes the code to use idx() so that it correctly returns null instead.

Test Plan

Tested in production.

Diff Detail

Repository
rP Phabricator
Branch
harbormaster-artifact-error
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6370
Build 6392: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Prevent an error when the Drydock lease artifact does not exist.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2015, 2:29 PM
This revision was automatically updated to reflect the committed changes.