Differential D13069

Generated ghost events should start generating as early as the range start minus the duration of the event.
ClosedPublic
Actions

Authored by lpriestley on May 29 2015, 9:53 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8347: Recurring events start generating at range start, but should start generating at (range start - event duration)

Commits

Restricted Diffusion Commit
rP447c372cfe6c: Generated ghost events should start generating as early as the range start…

Summary

Fixes T8347, Generated ghost events should start generating as early as the range start minus the duration of the event.

Test Plan

Create a year long weekly event, a year later, each day should have about 52 events.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 31532.May 29 2015, 9:53 PM

lpriestley retitled this revision from to Generated ghost events should start generating as early as the range start minus the duration of the event..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8347: Recurring events start generating at range start, but should start generating at (range start - event duration).

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 29 2015, 9:53 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I *think* that extending the end date is unnecessary here.

At some point, we should probably show some kind of "..." or "Click HERE to see 76 more events!" item at the bottom of days which have their event lists cut off, to make it clear that there's more stuff and we just cut it off.

This revision is now accepted and ready to land.May 29 2015, 10:30 PM

Closed by commit rP447c372cfe6c: Generated ghost events should start generating as early as the range start… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 29 2015, 10:46 PM

This revision was automatically updated to reflect the committed changes.