Page MenuHomePhabricator

Fix reverting commit language
ClosedPublic

Authored by joshuaspence on May 29 2015, 12:15 PM.
Tags
None
Referenced Files
F15474645: D13067.id31528.diff
Sun, Apr 6, 10:58 AM
F15457885: D13067.diff
Sun, Mar 30, 7:49 PM
F15453360: D13067.diff
Sat, Mar 29, 11:10 AM
F15423000: D13067.id.diff
Sat, Mar 22, 11:57 AM
Unknown Object (File)
Feb 22 2025, 7:40 AM
Unknown Object (File)
Feb 18 2025, 2:07 AM
Unknown Object (File)
Feb 12 2025, 1:31 PM
Unknown Object (File)
Feb 11 2025, 9:18 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPebde9357c7f8: Fix reverting commit language
Summary

I think the language here is inverted? On a commit which is reverted, the text states $author added a reverted commit: $commit. In reality, $commit is the reverting commit, not the reverted commit.

Test Plan

Think about English.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6361
Build 6383: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix reverting commit language.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 31 2015, 2:29 PM
This revision was automatically updated to reflect the committed changes.