Always return an array from ArcanistWorkflow->loadProjectRepository()
ClosedPublic
Actions

Authored by epriestley on May 28 2015, 11:10 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T8344: `arc land` Exception; null passed to `idx()`

Commits

rARCcdaa0e32e473: Always return an array from ArcanistWorkflow->loadProjectRepository()

Summary

Fixes T8344. Prior to D12971, this always returned array(). It may now sometimes return null. Switch the behavior to be more similar to the old behavior.

Test Plan

Inspection.

Diff Detail

Repository

rARC Arcanist

Branch

nullproj

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6349
Build 6371: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31514.May 28 2015, 11:10 PM

epriestley retitled this revision from to Always return an array from ArcanistWorkflow->loadProjectRepository().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T8344: `arc land` Exception; null passed to `idx()`.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 28 2015, 11:10 PM

joshuaspence accepted this revision.May 28 2015, 11:10 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.May 28 2015, 11:10 PM

Closed by commit rARCcdaa0e32e473: Always return an array from ArcanistWorkflow->loadProjectRepository() (authored by epriestley, committed by epriestley). · Explain WhyMay 28 2015, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistWorkflow.php

2 lines

Diff 31514

View Options

src/workflow/ArcanistWorkflow.php

Always return an array from ArcanistWorkflow->loadProjectRepository()ClosedPublicActions