Fix synthetic (lint) inline comments for comment hiding
ClosedPublic
Actions

Authored by epriestley on May 27 2015, 10:46 PM.

Tags

None

Referenced Files

	F14350133: D13042.diff
	Thu, Dec 19, 6:52 AM

	Unknown Object (File)
	Wed, Dec 18, 6:39 AM

	Unknown Object (File)
	Tue, Dec 10, 9:16 PM

	Unknown Object (File)
	Tue, Dec 10, 3:50 AM

	Unknown Object (File)
	Sun, Dec 8, 8:44 PM

	Unknown Object (File)
	Wed, Dec 4, 11:52 PM

	Unknown Object (File)
	Sun, Dec 1, 1:11 PM

	Unknown Object (File)
	Wed, Nov 27, 2:39 AM

View All Files

Subscribers

epriestley

Details

Reviewers

joshuaspence
btrahan

Commits

Restricted Diffusion Commit
rP5aa4044a9d38: Fix synthetic (lint) inline comments for comment hiding

Summary

These could cause F442758.

Test Plan

Screen Shot 2015-05-27 at 3.44.56 PM.png (219×815 px, 27 KB)

Diff Detail

Repository

rP Phabricator

Branch

synthetichide

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6323
Build 6345: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31468.May 27 2015, 10:46 PM

epriestley retitled this revision from to Fix synthetic (lint) inline comments for comment hiding.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 27 2015, 10:46 PM

joshuaspence accepted this revision.May 27 2015, 10:47 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.May 27 2015, 10:47 PM

Closed by commit rP5aa4044a9d38: Fix synthetic (lint) inline comments for comment hiding (authored by epriestley, committed by epriestley). · Explain WhyMay 27 2015, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialInlineComment.php

6 lines

Diff 31468

View Options

src/applications/differential/storage/DifferentialInlineComment.php

Fix synthetic (lint) inline comments for comment hidingClosedPublicActions