Differential D13028

Use ApplicationTransactions for all non-path edits to Owners packages
ClosedPublic
Actions

Authored by epriestley on May 26 2015, 11:22 PM.

Tags

None

Referenced Files

	F19800736: D13028.id31416.diff
	Sat, Feb 28, 5:47 PM

	F19729973: D13028.diff
	Sat, Feb 14, 10:03 AM

	F19729970: D13028.diff
	Sat, Feb 14, 10:02 AM

	F19729967: D13028.diff
	Sat, Feb 14, 10:02 AM

	F19561766: D13028.id.diff
	Jan 31 2026, 11:44 AM

	F18949565: D13028.id31447.diff
	Nov 12 2025, 1:05 AM

	F18822205: D13028.diff
	Oct 23 2025, 4:56 AM

	F18821207: D13028.id.diff
	Oct 22 2025, 8:25 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T8320: Bring Owners out of the dark ages

Commits

Restricted Diffusion Commit
rPda9a61fb70db: Use ApplicationTransactions for all non-path edits to Owners packages

Summary

Ref T8320.

Test Plan

Screen Shot 2015-05-26 at 4.21.27 PM.png (327×643 px, 54 KB)

Diff Detail

Repository

Branch

owners4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6299
Build 6321: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31416.May 26 2015, 11:22 PM

epriestley retitled this revision from to Use ApplicationTransactions for all non-path edits to Owners packages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8320: Bring Owners out of the dark ages.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 26 2015, 11:22 PM

btrahan accepted this revision.May 27 2015, 5:14 PM

btrahan edited edge metadata.

btrahan added inline comments.

resources/sql/autopatches/20150526.owners.mailkey.2.php
1–18	maybs we should support this in automagically in bin/storage ? I guess we're probably too low on legacy code to make that worthwhile now.

This revision is now accepted and ready to land.May 27 2015, 5:14 PM

epriestley added inline comments.May 27 2015, 5:22 PM

resources/sql/autopatches/20150526.owners.mailkey.2.php
1–18	Yeah, it does feel a bit like a ragged edge but if there are only like 4 more of them it doesn't feel worthwhile to generalize. I'm not sure if the real number is ~4 or ~20. Seems like it should probably be closer to 4 by now, though. Hopefully.

Closed by commit rPda9a61fb70db: Use ApplicationTransactions for all non-path edits to Owners packages (authored by epriestley, committed by epriestley). · Explain WhyMay 27 2015, 5:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20150526.owners.mailkey.1.sql

2 lines

20150526.owners.mailkey.2.php

18 lines

20150526.owners.xaction.sql

19 lines

src/

__phutil_library_map__.php

7 lines

applications/

owners/

controller/

PhabricatorOwnersDetailController.php

6 lines

PhabricatorOwnersEditController.php

154 lines

editor/

PhabricatorOwnersPackageTransactionEditor.php

240 lines

query/

PhabricatorOwnersPackageTransactionQuery.php

10 lines

storage/

PhabricatorOwnersPackage.php

46 lines

PhabricatorOwnersPackageTransaction.php

152 lines

infrastructure/

internationalization/

translation/

PhabricatorUSEnglishTranslation.php

18 lines

Diff 31416

resources/sql/autopatches/20150526.owners.mailkey.1.sql

Loading...

resources/sql/autopatches/20150526.owners.mailkey.2.php

Loading...

resources/sql/autopatches/20150526.owners.xaction.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...

src/applications/owners/controller/PhabricatorOwnersEditController.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php

Loading...

src/applications/owners/query/PhabricatorOwnersPackageTransactionQuery.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php

Loading...

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...