Page MenuHomePhabricator
Differential D13026

Separate editing of package data and paths in Owners
ClosedPublic
Actions

Authored by epriestley on May 26 2015, 8:57 PM.
Tags
None
Referenced Files
F15467995: D13026.id.diff
Thu, Apr 3, 7:08 PM
F15466977: D13026.id.diff
Thu, Apr 3, 11:27 AM
F15465366: D13026.diff
Wed, Apr 2, 5:51 PM
F15460736: D13026.id.diff
Tue, Apr 1, 1:39 AM
F15449184: D13026.id.diff
Fri, Mar 28, 8:47 AM
F15437409: D13026.id.diff
Tue, Mar 25, 7:16 PM
F15420207: D13026.id31411.diff
Fri, Mar 21, 12:10 PM
F15418282: D13026.id.diff
Thu, Mar 20, 10:15 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8320: Bring Owners out of the dark ages
Commits
Restricted Diffusion Commit
rP009598593f80: Separate editing of package data and paths in Owners
Summary

Ref T8320. There's currently one enormous form; split it into a general information form (name, description, owners) and a paths form.

I think this is a little more manageable from both a UX point of view and from an "I have to convert this to use ApplicationTransactions" point of view.

Test Plan
  • Edited paths.
  • Edited non-path information.
  • Created new packages.

Diff Detail

Repository
rP Phabricator
Branch
owners3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6295
Build 6317: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31411.May 26 2015, 8:57 PM
epriestley retitled this revision from to Separate editing of package data and paths in Owners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8320: Bring Owners out of the dark ages.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 26 2015, 8:57 PM
btrahan accepted this revision.May 27 2015, 5:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 27 2015, 5:12 PM
Closed by commit rP009598593f80: Separate editing of package data and paths in Owners (authored by epriestley, committed by epriestley). · Explain WhyMay 27 2015, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31411

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/owners/application/PhabricatorOwnersApplication.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersEditController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersPathsController.php

Loading...
Phabricator · Built by Phacility