Paths

Table of Contentst

Differential D12734

Remove the repositories application
ClosedPublic
Actions

Authored by joshuaspence on May 6 2015, 12:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 10, 3:12 AM

	Unknown Object (File)
	Thu, Nov 28, 4:49 PM

	Unknown Object (File)
	Mon, Nov 25, 8:44 AM

	Unknown Object (File)
	Nov 22 2024, 9:14 AM

	Unknown Object (File)
	Nov 22 2024, 7:32 AM

	Unknown Object (File)
	Nov 20 2024, 8:19 PM

	Unknown Object (File)
	Nov 17 2024, 2:21 AM

	Unknown Object (File)
	Nov 11 2024, 6:13 AM

Subscribers

Tokens

"Doubloon" token, awarded by epriestley.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7603: Remove the deprecated "Repositories" application

Commits

Restricted Diffusion Commit
rPc4bcfc85f160: Remove the repositories application

Summary

Fixes T7603. This application is no longer used.

Test Plan

Went to /repository/ and got a 404.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 6276
Build 6298: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	351 ms	PhabricatorCelerityTestCase::testCelerityMaps
	19 ms	PhabricatorConduitTestCase::testConduitMethods
	1 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled
	2 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
	1,394 ms	PhabricatorLibraryTestCase::testEverythingImplemented
		View Full Test Results (1 Failed · 6 Passed)

Event Timeline

joshuaspence updated this revision to Diff 30597.May 6 2015, 12:47 PM

joshuaspence retitled this revision from to [Draft] Remove the repositories application.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a task: T7603: Remove the deprecated "Repositories" application.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2015, 12:47 PM

Herald added a subscriber: epriestley. · View Herald Transcript

This (or some substantially equivalent future patch) is desirable when dependencies are resolved.

This revision is now accepted and ready to land.May 17 2015, 2:53 PM

Just confirming... I think this is basically safe to land now?

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptMay 25 2015, 9:33 PM

joshuaspence retitled this revision from [Draft] Remove the repositories application to Remove the repositories application.May 25 2015, 9:33 PM

joshuaspence updated this object.

joshuaspence removed a subscriber: Korvin.

joshuaspence edited the test plan for this revision. (Show Details)May 26 2015, 11:58 AM

I'm going to land this now... the Repositories application doesn't serve a purpose any longer.

Closed by commit rPc4bcfc85f160: Remove the repositories application (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 1 2015, 5:40 AM

This revision was automatically updated to reflect the committed changes.

epriestley awarded a token.Jun 1 2015, 1:47 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

repository/

application/

PhabricatorRepositoriesApplication.php

controller/

PhabricatorRepositoryController.php

PhabricatorRepositoryListController.php

Diff 31382

src/__phutil_library_map__.php

Loading...

src/applications/repository/application/PhabricatorRepositoriesApplication.php

Loading...

src/applications/repository/controller/PhabricatorRepositoryController.php

Loading...

src/applications/repository/controller/PhabricatorRepositoryListController.php

Loading...