Page MenuHomePhabricator
Differential D12889

Rename XHPAST build script
ClosedPublic
Actions

Authored by joshuaspence on May 17 2015, 9:58 PM.
Tags
None
Referenced Files
F14238686: D12889.id30994.diff
Thu, Dec 12, 3:51 PM
F14238614: D12889.id31169.diff
Thu, Dec 12, 3:41 PM
Unknown Object (File)
Wed, Dec 11, 4:44 AM
Unknown Object (File)
Tue, Dec 10, 3:01 PM
Unknown Object (File)
Sun, Dec 8, 10:14 AM
Unknown Object (File)
Sun, Dec 8, 4:48 AM
Unknown Object (File)
Fri, Dec 6, 3:52 PM
Unknown Object (File)
Fri, Dec 6, 8:23 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUcf22ba3c303e: Rename XHPAST build script
Summary

Historically XHPAST was built using a shell script, but it is now executed by PHP. We should eventually rename this file for consistency. To retain compatibility, we could possibly symlink build_xhpast.sh to build_xhpast.php and then check the value of $argv[0] and emit a deprecation warning if build_xhpast.sh was called.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30994.May 17 2015, 9:58 PM
joshuaspence retitled this revision from to Rename XHPAST build script.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2015, 9:58 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 31094.May 19 2015, 1:32 PM
joshuaspence edited edge metadata.

Remove shebang

joshuaspence updated this revision to Diff 31095.May 19 2015, 1:33 PM

Nevermind, we want to keep the shebang

epriestley requested changes to this revision.May 19 2015, 1:57 PM
epriestley edited edge metadata.

PhutilXHPASTBinary.php still has the old path, I think?

This revision now requires changes to proceed.May 19 2015, 1:57 PM
joshuaspence updated this revision to Diff 31150.May 19 2015, 9:11 PM
joshuaspence edited edge metadata.

Update help text

epriestley accepted this revision.May 19 2015, 11:39 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 11:39 PM
Closed by commit rPHUcf22ba3c303e: Rename XHPAST build script (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
build_xhpast.php
build_xhpast.sh
src/
parser/
xhpast/
bin/
2 lines

Diff 31169

View Options

scripts/build_xhpast.php

Loading...
View Options

scripts/build_xhpast.sh

Loading...
View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Loading...
Phabricator · Built by Phacility