Page MenuHomePhabricator
Differential D12940

Transactions - fix bug adding people to projects
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 2, 3:19 PM
Unknown Object (File)
Wed, May 28, 1:06 PM
Unknown Object (File)
Tue, May 27, 2:14 PM
Unknown Object (File)
May 6 2025, 7:35 PM
Unknown Object (File)
Apr 27 2025, 5:42 PM
Unknown Object (File)
Apr 25 2025, 6:37 AM
Unknown Object (File)
Apr 25 2025, 6:19 AM
Unknown Object (File)
Apr 23 2025, 3:17 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Like" token, awarded by epriestley.

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
T8264: Oddness adding people to the Dropbox project
Commits
Restricted Diffusion Commit
rP2154f17b3d7b: Transactions - fix bug adding people to projects
Summary

Fixes T8264. Broken in D12929. Sweep all the applyBuiltin implementations and always break; rather than return

Test Plan

added myself to a project successfully (showed up as a member)

Diff Detail

Repository
rP Phabricator
Branch
T8264
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6139
Build 6160: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 31158.May 19 2015, 10:21 PM
btrahan added a task: T8264: Oddness adding people to the Dropbox project.
btrahan retitled this revision from to Transactions - fix bug adding people to projects.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 10:21 PM
btrahan added a task: T6403: Make application customization of builtin transaction types optional.May 19 2015, 10:22 PM
Closed by commit rP2154f17b3d7b: Transactions - fix bug adding people to projects (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 10:22 PM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.May 19 2015, 11:38 PM

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
2 lines
differential/
editor/
2 lines
project/
editor/
6 lines

Diff 31158

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
Phabricator · Built by Phacility