Page MenuHomePhabricator

Transactions - fix inverse edge transaction writes
ClosedPublic

Authored by btrahan on May 19 2015, 9:26 PM.
Tags
None
Referenced Files
F18095809: D12939.id31154.diff
Fri, Aug 8, 2:36 AM
F18049916: D12939.id.diff
Sun, Aug 3, 5:48 PM
F18036957: D12939.id.diff
Sun, Aug 3, 2:23 AM
Unknown Object (File)
May 27 2025, 1:13 AM
Unknown Object (File)
Apr 25 2025, 6:37 AM
Unknown Object (File)
Apr 23 2025, 5:20 AM
Unknown Object (File)
Apr 21 2025, 3:22 PM
Unknown Object (File)
Apr 20 2025, 3:33 AM
Subscribers
Tokens
"Like" token, awarded by epriestley.

Details

Summary

Ref XXXXX. I broke things a bit in XXXXX in that if the TYPE_EDGE had an inverse transaction, we weren't correctly "doing nothing" and instead were falling back to our old every editor has to implement a no-op ways... Fix things by putting the TYPE_EDGE code in the handle external builtin function like it belongs.

Test Plan

made a comment on a task referencng a commit successfully

Diff Detail

Repository
rP Phabricator
Branch
T6403-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6138
Build 6159: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - fix inverse edge transaction writes.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision was automatically updated to reflect the committed changes.