Page MenuHomePhabricator

Transactions - make TYPE_COMMENT implementation optional
ClosedPublic

Authored by btrahan on May 19 2015, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 7:45 AM
Unknown Object (File)
Mon, Dec 23, 7:40 AM
Unknown Object (File)
Mon, Dec 23, 7:36 AM
Unknown Object (File)
Fri, Dec 20, 11:29 AM
Unknown Object (File)
Thu, Dec 19, 9:05 PM
Unknown Object (File)
Sat, Dec 14, 7:40 PM
Unknown Object (File)
Tue, Dec 10, 3:58 PM
Unknown Object (File)
Wed, Dec 4, 6:42 PM
Subscribers
Tokens
"Haypence" token, awarded by epriestley.

Details

Summary

Ref T6403. Conpherence keeps track of comments for message counts so we needed some special attention there. Otherwise, straight-forward.

Test Plan

left a comment on a diff with inline comments. sent messages in conpherence successfully. verified unread count incremented correctly for sent messages for users.

Diff Detail

Repository
rP Phabricator
Branch
T6403
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6127
Build 6148: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - make TYPE_COMMENT implementation optional.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/editor/ConpherenceEditor.php
303

Maybe just break; in case the parent ever does anything.

This revision is now accepted and ready to land.May 19 2015, 7:32 PM
btrahan edited edge metadata.

go with break; rather than return; so the parent can be fancy maybe some day

This revision was automatically updated to reflect the committed changes.