Page MenuHomePhabricator

People - fix hovercards for people
ClosedPublic

Authored by btrahan on May 18 2015, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 2:38 PM
Unknown Object (File)
Mon, Apr 29, 2:38 PM
Unknown Object (File)
Mon, Apr 29, 2:38 PM
Unknown Object (File)
Mon, Apr 29, 2:38 PM
Unknown Object (File)
Thu, Apr 25, 1:32 PM
Unknown Object (File)
Sat, Apr 20, 10:31 AM
Unknown Object (File)
Sat, Apr 20, 10:31 AM
Unknown Object (File)
Sat, Apr 20, 10:31 AM
Subscribers

Details

Summary

Fixes T8242. D12833 removed the title as well as the blurb from people hovercards. When re-adding the title don't bother throwing things through pht since that seems like not something you translate exactly and also lose the flavor text which most users end up having since title is rarely set (at least on this install).

Test Plan

viewed hovercards and saw title and blurb again as appropos relative to the data being set

Diff Detail

Repository
rP Phabricator
Branch
T8242
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6088
Build 6108: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to People - fix hovercards for people.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.

I removed this mostly-on-purpose because almost no one sets their title so hovercards are dominated by the ridiculously long default flavor text, from what I've seen. Maybe drop that? I don't really feel strongly here.

This revision is now accepted and ready to land.May 18 2015, 10:01 PM
btrahan edited edge metadata.

losing the flavortext

btrahan edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.