Add a linter rule for invalid default parameters
ClosedPublic
Actions

Authored by joshuaspence on May 15 2015, 8:31 AM.

Tags

None

Referenced Files

	F19638437: D12855.diff
	Feb 5 2026, 4:09 PM

	F19551913: D12855.id31016.diff
	Jan 28 2026, 8:42 PM

	F18933518: D12855.diff
	Nov 10 2025, 11:42 AM

	F18846674: D12855.id31016.diff
	Oct 29 2025, 8:30 PM

	F18829808: D12855.id.diff
	Oct 25 2025, 1:15 AM

	F18783503: D12855.id31061.diff
	Oct 13 2025, 7:16 AM

	F18772079: D12855.id30925.diff
	Oct 9 2025, 12:08 AM

	F18763981: D12855.diff
	Oct 7 2025, 3:26 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC60a5a2403360: Add a linter rule for invalid default parameters

Summary

See http://www.phpwtf.org/default-arguments-and-type-hinting.

Test Plan

Added test case.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30925.May 15 2015, 8:31 AM

joshuaspence retitled this revision from to Add a linter rule for invalid default parameters.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 8:31 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 17 2015, 12:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2015, 12:59 PM

Rebase

Closed by commit rARC60a5a2403360: Add a linter rule for invalid default parameters (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 18 2015, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

76 lines

__tests__/

xhpast/

invalid-default-paramter.lint-test

17 lines

Diff 31061

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/invalid-default-paramter.lint-test

Add a linter rule for invalid default parametersClosedPublicActions