Page MenuHomePhabricator
Differential D12907

Destroy notifications properly from `bin/remove destroy`
ClosedPublic
Actions

Authored by epriestley on May 18 2015, 7:28 PM.
Tags
None
Referenced Files
F18195433: D12907.diff
Sun, Aug 17, 3:45 PM
F18118775: D12907.diff
Wed, Aug 13, 9:10 AM
F18108764: D12907.id31045.diff
Mon, Aug 11, 9:22 AM
F18096124: D12907.id31046.diff
Fri, Aug 8, 4:33 AM
F18052281: D12907.id.diff
Mon, Aug 4, 2:02 AM
F17863149: D12907.id31046.diff
Mon, Jul 28, 12:42 AM
F17854068: D12907.id31045.diff
Sun, Jul 27, 2:37 PM
Unknown Object (File)
Jun 7 2025, 11:39 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error.
Commits
Restricted Diffusion Commit
rP4250719d1008: Destroy notifications properly from `bin/remove destroy`
Summary

Fixes T8237. This table is unusual and doesn't have an id column, so delete() doesn't actually know how to delete records and fails.

Test Plan
  • Used bin/remove destroy to destroy an object with notifications, as per T8237.
  • Applied patch.
  • Used bin/remove destroy to get a clean delete.
  • Verified related notifications vanished from notification menu.

Diff Detail

Repository
rP Phabricator
Branch
destroynotif
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6075
Build 6095: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31045.May 18 2015, 7:28 PM
epriestley retitled this revision from to Destroy notifications properly from `bin/remove destroy`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error..
Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2015, 7:28 PM
btrahan accepted this revision.May 18 2015, 7:29 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 7:29 PM
Closed by commit rP4250719d1008: Destroy notifications properly from `bin/remove destroy` (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2015, 7:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
system/
engine/
13 lines

Diff 31045

View Options

src/applications/system/engine/PhabricatorDestructionEngine.php

Loading...
Phabricator · Built by Phacility